Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for magnet links #503

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix parsing for magnet links #503

merged 1 commit into from
Dec 4, 2024

Conversation

nfrasser
Copy link
Owner

@nfrasser nfrasser commented Dec 4, 2024

Fixes #410

Specifically any optionalSlashSlash scheme followed by a question mark, e.g., magnet:?data...

Requires registering magnet:

linkify.registerCustomProtocol('magnet', true)

Specically any optionalSlashSlash scheme followed by a question mark,
e.g., magnet:?data...
@nfrasser nfrasser self-assigned this Dec 4, 2024
@nfrasser nfrasser merged commit 606feca into main Dec 4, 2024
4 checks passed
@nfrasser nfrasser deleted the magnet-link branch December 4, 2024 06:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12154065466

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.69%

Totals Coverage Status
Change from base Build 12154007097: 0.001%
Covered Lines: 2871
Relevant Lines: 2917

💛 - Coveralls

@nfrasser nfrasser changed the title Allow parsing magnet links Fix parsing for magnet links Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If magnet scheme is not added destroys the visual result
2 participants