Allow parsing magnet links (#503)

Specically any optionalSlashSlash scheme followed by a question mark, e.g., magnet:?data...
nfrasser · Dec 4, 2024 · 606feca · 606feca
1 parent 9183db6
commit 606feca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/linkifyjs/src/parser.mjs b/packages/linkifyjs/src/parser.mjs
@@ -54,6 +54,7 @@ export function init({ groups }) {
 		tk.COMMA,
 		tk.DOT,
 		tk.EXCLAMATION,
+		tk.PERCENT,
 		tk.QUERY,
 		tk.QUOTE,
 		tk.SEMI,
@@ -211,6 +212,7 @@ export function init({ groups }) {
 	// Force URL with scheme prefix followed by anything sane
 	ta(SchemeColon, groups.domain, Url);
 	tt(SchemeColon, tk.SLASH, Url);
+	tt(SchemeColon, tk.QUERY, Url);
 	ta(UriPrefix, groups.domain, Url);
 	ta(UriPrefix, qsAccepting, Url);
 	tt(UriPrefix, tk.SLASH, Url);

diff --git a/test/spec/linkifyjs.test.mjs b/test/spec/linkifyjs.test.mjs
@@ -37,8 +37,9 @@ describe('linkifyjs', () => {
 
 	describe('registerCustomProtocol', () => {
 		beforeEach(() => {
-			linkify.registerCustomProtocol('instagram', true);
 			linkify.registerCustomProtocol('view-source');
+			linkify.registerCustomProtocol('instagram', true);
+			linkify.registerCustomProtocol('magnet', true);
 		});
 
 		it('Detects basic protocol', () => {
@@ -49,6 +50,12 @@ describe('linkifyjs', () => {
 			expect(linkify.test('instagram://user/nfrasser', 'url')).to.be.ok;
 		});
 
+		it('Detects magnet protocol', () => {
+			const magnetLink =
+				'magnet:?xt=urn:btih:5a7f5e0f3ce439e2f1a83e718a8405ec8809110b&dn=ernfkjenrkfk%5FSQ80%5FV%5Fv1.0.0%5Ferfnkerkf%5Ferfnkerkfefrfvegrteggt.net.rar';
+			expect(linkify.test(magnetLink, 'url')).to.be.ok;
+		});
+
 		it('Detects compound protocol', () => {
 			expect(linkify.test('view-source://http://github.com/', 'url')).to.be.ok;
 		});