Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csvtk and change stageIn pattern of csvtk/concat #7267

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

dialvarezs
Copy link
Contributor

@dialvarezs dialvarezs commented Jan 2, 2025

Bumps csvtk version on modules csvtk/concat, csvtk/join and csvtk/split.
It also modifies the input pattern of csvtk/concat to prevent name clashes.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@dialvarezs
Copy link
Contributor Author

I added the same file twice to the test to really check if repeated filenames are handled as expected.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then.

@dialvarezs dialvarezs added this pull request to the merge queue Jan 8, 2025
Merged via the queue into nf-core:master with commit aa5c230 Jan 8, 2025
32 checks passed
@dialvarezs dialvarezs deleted the dev-csvtk branch January 8, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants