Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BBMAP/REPAIR submodule #7249

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added BBMAP/REPAIR submodule #7249

wants to merge 3 commits into from

Conversation

mazzalab
Copy link
Contributor

@mazzalab mazzalab commented Dec 19, 2024

Added the repair.sh BBMap's submodule

PR checklist

Closes #7248

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@mazzalab mazzalab added WIP Work in progress update module labels Dec 19, 2024
@mazzalab mazzalab requested a review from SPPearce December 19, 2024 09:47
@mazzalab mazzalab self-assigned this Dec 19, 2024
@mazzalab
Copy link
Contributor Author

Hi @SPPearce, can you suggest how to set up the prefix in this case to comply with the recommendations?

@SPPearce
Copy link
Contributor

Hi @SPPearce, can you suggest how to set up the prefix in this case to comply with the recommendations?

Ok, here you have two distinct things that are being emitted, so I can see the reason to have to name them with a fixed suffix.

@mazzalab
Copy link
Contributor Author

OK I finalized the module. Have you @SPPearce time for a quick review?

SPPearce
SPPearce previously approved these changes Dec 24, 2024
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

modules/nf-core/bbmap/repair/tests/nextflow.config Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update module: BBMAP/REPAIR
3 participants