-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weighted sampling docs #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
victorlin
force-pushed
the
victorlin/add-weighted-sampling-docs
branch
from
August 19, 2024 19:38
872bddc
to
2c06854
Compare
victorlin
force-pushed
the
victorlin/update-subsampling-docs
branch
from
August 19, 2024 21:54
5962ddb
to
65f8fe4
Compare
1 task
victorlin
force-pushed
the
victorlin/add-weighted-sampling-docs
branch
from
August 19, 2024 22:01
2c06854
to
522fe9c
Compare
victorlin
force-pushed
the
victorlin/update-subsampling-docs
branch
from
August 19, 2024 22:57
65f8fe4
to
b5cb803
Compare
victorlin
force-pushed
the
victorlin/add-weighted-sampling-docs
branch
from
August 19, 2024 22:57
522fe9c
to
17ca960
Compare
victorlin
force-pushed
the
victorlin/update-subsampling-docs
branch
3 times, most recently
from
August 20, 2024 23:35
62e01e5
to
5779a70
Compare
I plan to use actual values in subsequent examples. Region gets the point across in a more politically neutral way.
victorlin
force-pushed
the
victorlin/add-weighted-sampling-docs
branch
from
August 20, 2024 23:40
17ca960
to
76ff695
Compare
Probabilistic sampling is really a special case of uniform sampling, not a separate sampling method. Make it a section under caveats.
This makes it easier to add a section on weighted sampling, which also falls under grouped sampling and shares the same caveats as uniform sampling.
Add a new section and adjust existing content accordingly.
Weighted sampling makes this scenario technically feasible, but practically difficult to achieve in a single augur filter call. Explain this trade-off in detail.
victorlin
force-pushed
the
victorlin/add-weighted-sampling-docs
branch
from
August 21, 2024 22:02
f4443a5
to
c6084f3
Compare
5 tasks
genehack
approved these changes
Aug 22, 2024
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
Adding docs for nextstrain/augur#1318
Checklist