[preview 1] Move panel toggles to control headers #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hooks API is recommended by Redux docs¹. ¹ https://react-redux.js.org/api/hooks
Do this by extending annotatedHeader to take an optional toggle, then using it for all available panels. Simplify headers and translations to just the panel name (e.g. Tree) instead of "Show <panel name>" / "<panel name> Options". Repurpose and move the section "Panel Options" to the top as "Layout". Conditionally render that entire section including the header.
This keeps the styling closer to where it is used.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-move--vboshc
victorlin
force-pushed
the
victorlin/move-panel-toggles
branch
from
16e680b
to
9838191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototyping for #1704. For preview purposes only. Do not merge.