Drop node14, update testing #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nextstrain/docker-base#122 is merged so I'm going to rebase this onto latest |
Node.js v14 went from LTS to end-of-life status on 2023-04-30¹. Both of our internal consumers of auspice (auspice.us, nextstrain) use node v16. This commit parallels 402828c (2023-03-03) which removed support for node v12. ¹ https://github.com/nodejs/release#release-schedule
As recommended by `npm audit` The removal of the line in `puppeteer.setup.js` was motivated by the introduced error "TypeError: page._client.send is not a function". I'm reasonably confident that line was related to integration tests removed in a previous commit. Note that this version of puppeteer uses nullish coalescing assignment which is not supported by node.js v14.
victorlin
force-pushed
the
update-testing-part-2
branch
from
b7db573
to
cd0f21e
Compare
jameshadfield
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was originally part of #1672 and #1673.
As it removes support for node.js v14 it is blocked on nextstrain/docker-base#122