Fix GitHub repository provider when providing token with auth property #6662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the authentication logic for the
GithubRepositoryProviderto prioritize a user-specified token over theGITHUB_TOKENenvironment variable, and adds a corresponding test to ensure this behavior.Authentication logic improvements:
getUser()andgetPassword()methods inGithubRepositoryProviderto use a user-specified token (via the provider config) before falling back to theGITHUB_TOKENenvironment variable. This ensures that explicit credentials take precedence over environment-based ones.Testing enhancements:
GithubRepositoryProviderTestto verify that when both a user-specified token and aGITHUB_TOKENenvironment variable are present, the user-specified token is used for authentication.