-
Notifications
You must be signed in to change notification settings - Fork 751
Add README files for all plugins #6660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e364d8f to
17f04b9
Compare
- Add README.md files for all plugins following the nextflow-plugin-gradle requirements - Each README includes: Summary, Get Started, Examples, Resources, and License sections - Disable generateSpec in build.gradle for all plugins (temporary workaround) Signed-off-by: Paolo Di Tommaso <[email protected]>
17f04b9 to
fd27493
Compare
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some suggestions to name the plugin in the first sentence to improve clarity, but otherwise looks good.
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
|
Awesome thanks |
| To use this plugin, add it to your `nextflow.config`: | ||
|
|
||
| ```groovy | ||
| plugins { | ||
| id 'nf-amazon' | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unnecessary since core plugins are enabled automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for all the other READMEs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, however it may be better to keep for consistency with plugin config syntax
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added suggestions to change the headings into sentence case, which we use for regular documentation.
| 1. **Summary** - Explain what the plugin does | ||
| 2. **Get Started** - Setup and configuration instructions | ||
| 3. **Examples** - Code examples with code blocks | ||
| 4. **License** - Specify the plugin's license (e.g., Apache 2.0, MIT, GPL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. **Summary** - Explain what the plugin does | |
| 2. **Get Started** - Setup and configuration instructions | |
| 3. **Examples** - Code examples with code blocks | |
| 4. **License** - Specify the plugin's license (e.g., Apache 2.0, MIT, GPL) | |
| 1. **Summary:** Explain what the plugin does | |
| 2. **Get started:** Setup and configuration instructions | |
| 3. **Examples:** Provide code examples with code blocks | |
| 4. **License:** Specify the plugin's license (e.g., Apache 2.0, MIT, GPL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the code, but will these headings be tested/checked for in PRs?
If so, are the headings case sensitive? Are there requirements for their level (e.g., H2 or H3)?
|
|
||
| The Amazon Web Services (AWS) plugin provides support for AWS, including AWS Batch as a compute executor, S3 as a file system, and Fusion file system for high-performance data operations. | ||
|
|
||
| ## Get Started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Get Started | |
| ## Get started |
|
|
||
| ## Examples | ||
|
|
||
| ### Basic AWS Batch Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Basic AWS Batch Configuration | |
| ### Basic AWS Batch configuration |
| } | ||
| ``` | ||
|
|
||
| ### Using Fusion File System |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Using Fusion File System | |
| ### Using Fusion file system |
| workDir = 's3://my-bucket/work' | ||
| ``` | ||
|
|
||
| ### S3 Storage Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### S3 Storage Options | |
| ### S3 storage options |
| } | ||
| ``` | ||
|
|
||
| ### Reports and Cache Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Reports and Cache Management | |
| ### Reports and cache management |
|
|
||
| The Wave containers plugin provides integration with the Wave container service for dynamic container building, augmentation, and on-demand software provisioning. | ||
|
|
||
| ## Get Started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Get Started | |
| ## Get started |
| ### Basic Wave Configuration | ||
|
|
||
| ```groovy | ||
| plugins { | ||
| id 'nf-wave' | ||
| } | ||
| wave { | ||
| enabled = true | ||
| } | ||
| process { | ||
| conda = 'samtools=1.17' | ||
| } | ||
| ``` | ||
|
|
||
| ### Using Wave with Conda Packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Basic Wave Configuration | |
| ```groovy | |
| plugins { | |
| id 'nf-wave' | |
| } | |
| wave { | |
| enabled = true | |
| } | |
| process { | |
| conda = 'samtools=1.17' | |
| } | |
| ``` | |
| ### Using Wave with Conda Packages | |
| ### Basic Wave configuration | |
| ```groovy | |
| plugins { | |
| id 'nf-wave' | |
| } | |
| wave { | |
| enabled = true | |
| } | |
| process { | |
| conda = 'samtools=1.17' | |
| } | |
| ``` | |
| ### Using Wave with Conda packages |
| } | ||
| ``` | ||
|
|
||
| ### Wave with Fusion File System |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Wave with Fusion File System | |
| ### Wave with Fusion file system |
| ### Container Augmentation | ||
|
|
||
| ```groovy | ||
| wave { | ||
| enabled = true | ||
| strategy = 'conda,container' | ||
| } | ||
| process TOOL { | ||
| container 'ubuntu:22.04' | ||
| conda 'bioconda::samtools=1.17' | ||
| script: | ||
| ''' | ||
| samtools --version | ||
| ''' | ||
| } | ||
| ``` | ||
|
|
||
| ### Using Private Registries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Container Augmentation | |
| ```groovy | |
| wave { | |
| enabled = true | |
| strategy = 'conda,container' | |
| } | |
| process TOOL { | |
| container 'ubuntu:22.04' | |
| conda 'bioconda::samtools=1.17' | |
| script: | |
| ''' | |
| samtools --version | |
| ''' | |
| } | |
| ``` | |
| ### Using Private Registries | |
| ### Container augmentation | |
| ```groovy | |
| wave { | |
| enabled = true | |
| strategy = 'conda,container' | |
| } | |
| process TOOL { | |
| container 'ubuntu:22.04' | |
| conda 'bioconda::samtools=1.17' | |
| script: | |
| ''' | |
| samtools --version | |
| ''' | |
| } | |
| ``` | |
| ### Using private registries |
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added suggestions to change the headings into sentence case, which we use for regular documentation.
Summary
generateSpecin build.gradle for all pluginsChanges
New README files
plugins/nf-amazon/README.mdplugins/nf-azure/README.md(updated)plugins/nf-cloudcache/README.mdplugins/nf-codecommit/README.mdplugins/nf-console/README.mdplugins/nf-google/README.mdplugins/nf-k8s/README.mdplugins/nf-tower/README.mdplugins/nf-wave/README.mdBuild configuration
generateSpec = falseto all plugin build.gradle filesTest plan
./gradlew releasePluginToRegistryIfNotExiststo verify plugin release works🤖 Generated with Claude Code