Skip to content

Conversation

@pditommaso
Copy link
Member

@pditommaso pditommaso commented Dec 13, 2025

Summary

  • Add README.md files for all 9 plugins following the nextflow-plugin-gradle requirements
  • Each README includes: Summary, Get Started, Examples, Resources, and License sections
  • Disable generateSpec in build.gradle for all plugins

Changes

New README files

  • plugins/nf-amazon/README.md
  • plugins/nf-azure/README.md (updated)
  • plugins/nf-cloudcache/README.md
  • plugins/nf-codecommit/README.md
  • plugins/nf-console/README.md
  • plugins/nf-google/README.md
  • plugins/nf-k8s/README.md
  • plugins/nf-tower/README.md
  • plugins/nf-wave/README.md

Build configuration

  • Added generateSpec = false to all plugin build.gradle files

Test plan

  • Verify README files are correctly formatted
  • Run ./gradlew releasePluginToRegistryIfNotExists to verify plugin release works

🤖 Generated with Claude Code

@netlify
Copy link

netlify bot commented Dec 13, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 72aa88c
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/6941abcf13eda200080cef5e
😎 Deploy Preview https://deploy-preview-6660--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

- Add README.md files for all plugins following the nextflow-plugin-gradle requirements
- Each README includes: Summary, Get Started, Examples, Resources, and License sections
- Disable generateSpec in build.gradle for all plugins (temporary workaround)

Signed-off-by: Paolo Di Tommaso <[email protected]>
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions to name the plugin in the first sentence to improve clarity, but otherwise looks good.

pditommaso and others added 9 commits December 15, 2025 09:15
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso
Copy link
Member Author

Awesome thanks

Comment on lines +7 to +13
To use this plugin, add it to your `nextflow.config`:

```groovy
plugins {
id 'nf-amazon'
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary since core plugins are enabled automatically

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all the other READMEs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, however it may be better to keep for consistency with plugin config syntax

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso requested a review from a team as a code owner December 16, 2025 17:56
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added suggestions to change the headings into sentence case, which we use for regular documentation.

Comment on lines +98 to +101
1. **Summary** - Explain what the plugin does
2. **Get Started** - Setup and configuration instructions
3. **Examples** - Code examples with code blocks
4. **License** - Specify the plugin's license (e.g., Apache 2.0, MIT, GPL)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **Summary** - Explain what the plugin does
2. **Get Started** - Setup and configuration instructions
3. **Examples** - Code examples with code blocks
4. **License** - Specify the plugin's license (e.g., Apache 2.0, MIT, GPL)
1. **Summary:** Explain what the plugin does
2. **Get started:** Setup and configuration instructions
3. **Examples:** Provide code examples with code blocks
4. **License:** Specify the plugin's license (e.g., Apache 2.0, MIT, GPL)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the code, but will these headings be tested/checked for in PRs?

If so, are the headings case sensitive? Are there requirements for their level (e.g., H2 or H3)?


The Amazon Web Services (AWS) plugin provides support for AWS, including AWS Batch as a compute executor, S3 as a file system, and Fusion file system for high-performance data operations.

## Get Started
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Get Started
## Get started


## Examples

### Basic AWS Batch Configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Basic AWS Batch Configuration
### Basic AWS Batch configuration

}
```

### Using Fusion File System
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Using Fusion File System
### Using Fusion file system

workDir = 's3://my-bucket/work'
```

### S3 Storage Options
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### S3 Storage Options
### S3 storage options

}
```

### Reports and Cache Management
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Reports and Cache Management
### Reports and cache management


The Wave containers plugin provides integration with the Wave container service for dynamic container building, augmentation, and on-demand software provisioning.

## Get Started
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Get Started
## Get started

Comment on lines +27 to +43
### Basic Wave Configuration

```groovy
plugins {
id 'nf-wave'
}
wave {
enabled = true
}
process {
conda = 'samtools=1.17'
}
```

### Using Wave with Conda Packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Basic Wave Configuration
```groovy
plugins {
id 'nf-wave'
}
wave {
enabled = true
}
process {
conda = 'samtools=1.17'
}
```
### Using Wave with Conda Packages
### Basic Wave configuration
```groovy
plugins {
id 'nf-wave'
}
wave {
enabled = true
}
process {
conda = 'samtools=1.17'
}
```
### Using Wave with Conda packages

}
```

### Wave with Fusion File System
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Wave with Fusion File System
### Wave with Fusion file system

Comment on lines +75 to +94
### Container Augmentation

```groovy
wave {
enabled = true
strategy = 'conda,container'
}
process TOOL {
container 'ubuntu:22.04'
conda 'bioconda::samtools=1.17'
script:
'''
samtools --version
'''
}
```

### Using Private Registries
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Container Augmentation
```groovy
wave {
enabled = true
strategy = 'conda,container'
}
process TOOL {
container 'ubuntu:22.04'
conda 'bioconda::samtools=1.17'
script:
'''
samtools --version
'''
}
```
### Using Private Registries
### Container augmentation
```groovy
wave {
enabled = true
strategy = 'conda,container'
}
process TOOL {
container 'ubuntu:22.04'
conda 'bioconda::samtools=1.17'
script:
'''
samtools --version
'''
}
```
### Using private registries

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added suggestions to change the headings into sentence case, which we use for regular documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants