-
Notifications
You must be signed in to change notification settings - Fork 753
Add support for gcp ops agent #6608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ejseqera
wants to merge
2
commits into
nextflow-io:master
Choose a base branch
from
ejseqera:add-support-gcp-ops-agent
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -923,6 +923,13 @@ The following settings are available: | |||||
| ::: | ||||||
| : List of custom mount options for `gcsfuse` (default: `['-o rw', '-implicit-dirs']`). | ||||||
|
|
||||||
| `google.batch.installOpsAgent` | ||||||
| : Enable the installation of the Ops Agent on Google Batch instances for enhanced monitoring and logging (default: `false`). | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I think the sentence could be simplified. Please check meaning is retained. |
||||||
|
|
||||||
| : :::{note} | ||||||
| The Ops Agent requires a compatible boot disk image. For Google Batch, use [Batch-debian images](https://docs.cloud.google.com/batch/docs/vm-os-environment-overview#vm-os-image-options) (e.g., `batch-debian`) with `google.batch.bootDiskImage`. The default Container-Optimized OS (`batch-cos`) is not compatible with the Ops Agent. | ||||||
| ::: | ||||||
|
|
||||||
| `google.batch.logsPath` | ||||||
| : :::{versionadded} 25.11.0-edge | ||||||
| ::: | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -410,6 +410,9 @@ class GoogleBatchTaskHandler extends TaskHandler implements FusionAwareTask { | |
| instancePolicyOrTemplate.setPolicy( instancePolicy ) | ||
| } | ||
|
|
||
| if( batchConfig.installOpsAgent ) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't it check if the boot disk image is compatible with the Ops Agent? |
||
| instancePolicyOrTemplate.setInstallOpsAgent( true ) | ||
|
|
||
| allocationPolicy.addInstances(instancePolicyOrTemplate) | ||
|
|
||
| // network policy | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -158,6 +158,7 @@ class GoogleBatchTaskHandlerTest extends Specification { | |
| getServiceAccountEmail() >> '[email protected]' | ||
| getSubnetwork() >> 'subnet-1' | ||
| usePrivateAddress >> true | ||
| installOpsAgent >> true | ||
| logsPath() >> LOGS_PATH | ||
| } | ||
| } | ||
|
|
@@ -224,6 +225,7 @@ class GoogleBatchTaskHandlerTest extends Specification { | |
| allocationPolicy.getLocation().getAllowedLocations(0) == 'zones/us-central1-a' | ||
| allocationPolicy.getLocation().getAllowedLocations(1) == 'zones/us-central1-c' | ||
| allocationPolicy.getInstances(0).getInstallGpuDrivers() == true | ||
| allocationPolicy.getInstances(0).getInstallOpsAgent() == true | ||
| allocationPolicy.getLabelsMap() == [foo: 'bar'] | ||
| allocationPolicy.getServiceAccount().getEmail() == '[email protected]' | ||
| allocationPolicy.getTagsList() == ['tag1', 'tag2'] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any good google cloud docs we could link to? I found this which seems okay