Skip to content

Conversation

@rcannood
Copy link
Contributor

@rcannood rcannood commented Oct 11, 2025

Makes the notifyEvent functionality asynchronous, as requested by @pditommaso in #6443:

This seems going into the right direction. My only connect is about the notification events, here

https://github.com/nextflow-io/nextflow/pull/6443/files#diff-cb4252ec3616353913180e8e6eb95c249b4d591daf4143283e543be188568685R105-R111

Likely those events should be emitter async in this context for two reasons:

  1. Make sure the target path is accessible when the event is received

  2. Avoid that core runtime performance could be impacted by compute/data intensive that could be implemented by third-parties plugins


Update: I had to change the return type of notifyEvent so notifyFlowComplete and notifyError can wait until all futures are resolved before continuing.

@netlify
Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit b29f66a
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68eb566c297cf500081d1fc5

Signed-off-by: Robrecht Cannoodt <[email protected]>
Signed-off-by: Robrecht Cannoodt <[email protected]>
@rcannood rcannood force-pushed the make-notifyevent-asynchronous branch from 5aeddc5 to 541c291 Compare October 12, 2025 05:00
@rcannood rcannood force-pushed the make-notifyevent-asynchronous branch from b3f70b1 to ec32571 Compare October 12, 2025 07:12
Signed-off-by: Robrecht Cannoodt <[email protected]>
@rcannood rcannood force-pushed the make-notifyevent-asynchronous branch from ec32571 to b29f66a Compare October 12, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant