Use the same antlr4 dep as Groovy 4 #5990
Merged
+1
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
Any chance having this finalised? |
|
Everything looks good with the language server. Ready to merge 😄 |
|
This change reduced the language server JAR from ~23 to ~13 MB. |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same antlr4 runtime as Groovy 4: https://github.com/apache/groovy/blob/deb89c45afe270e09cacd6a79408bfd527b5747a/build.gradle#L85
Should revert the recent increase in build size likely caused by having two antlr runtimes in the JAR.
I also need to check a few things with the language server. But let's see how the tests respond