Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Finder Sync Extension #5903

Merged
merged 12 commits into from
Jul 24, 2023
Merged

Fix Finder Sync Extension #5903

merged 12 commits into from
Jul 24, 2023

Commits on Jul 24, 2023

  1. Clean up FinderSyncExt processInBuffer 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2acec8f View commit details
    Browse the repository at this point in the history

  2. Fix parsing of in buffer lines in FinderSyncExt 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a0088dc View commit details
    Browse the repository at this point in the history

  3. Add quotes to processed line in FinderSyncExt to easily demarcate rec… 

    …eived line start and end

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    535402a View commit details
    Browse the repository at this point in the history

  4. Use modern dot notation to access _inBuffer properties 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e0da34d View commit details
    Browse the repository at this point in the history

  5. Define FinderSync internal data members as private interface extension 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    736e659 View commit details
    Browse the repository at this point in the history

  6. Correctly initialise internal data members for FinderSync 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    fe3104c View commit details
    Browse the repository at this point in the history

  7. Do not GENERATE_INFOPLIST_FILE for FinderSyncExt 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    8fa463b View commit details
    Browse the repository at this point in the history

  8. Fix BUILD_FILE_PROVIDER_MODULE check in application.cpp 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b4b51cf View commit details
    Browse the repository at this point in the history

  9. Fix optional compile of File Provider module 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4d359bd View commit details
    Browse the repository at this point in the history

  10. Allocate new unsigned char buffer for processed line in heap, fixing … 

    …crash

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    49a9f7f View commit details
    Browse the repository at this point in the history

  11. Use more informative NSAssert rather than assert for _registeredDirec… 

    …tories

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4954deb View commit details
    Browse the repository at this point in the history

  12. Operate directly on NSMutableData for incoming socket data, do not wo… 

    …rk with raw buffers

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1e9dbf8 View commit details
    Browse the repository at this point in the history