Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Finder Sync Extension #5903

Merged
merged 12 commits into from
Jul 24, 2023
Merged

Fix Finder Sync Extension #5903

merged 12 commits into from
Jul 24, 2023

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jul 20, 2023

This PR fixes the broken Finder Sync Extension in master. Specifically:

  • Fixes issues in the xcodeproj that would lead to the sytem not running the appex
  • Fixes broken code in the parsing for incoming bytes over the socket with the desktop client
  • Fixes the optional compile if the File Provider module

Closes #5755

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5903 (cd67afc) into master (8fc3c99) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head cd67afc differs from pull request most recent head 1e9dbf8. Consider uploading reports for the commit 1e9dbf8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5903      +/-   ##
==========================================
+ Coverage   60.08%   60.10%   +0.01%     
==========================================
  Files         145      145              
  Lines       18762    18746      -16     
==========================================
- Hits        11273    11267       -6     
+ Misses       7489     7479      -10     

see 5 files with indirect coverage changes

Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra kindly check my comments

…eived line start and end

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5903-1e9dbf8f14f12331cd065c9d2c37b5d9e67995b5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit a727971 into master Jul 24, 2023
10 checks passed
@claucambra claucambra deleted the bugfix/fix-findersyncext branch July 24, 2023 10:43
@backportbot-nextcloud
Copy link

The backport to stable-3.9 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.9
git pull origin stable-3.9

# Create the new backport branch
git checkout -b fix/foo-stable-3.9

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.9

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@claucambra
Copy link
Collaborator Author

Backport attempt was a mistake, no need as file provider inclusion was reverted in stable-3.9

@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nextcloud context menu broken in OSX Big Sur
4 participants