-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Finder Sync Extension #5903
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5903 +/- ##
==========================================
+ Coverage 60.08% 60.10% +0.01%
==========================================
Files 145 145
Lines 18762 18746 -16
==========================================
- Hits 11273 11267 -6
+ Misses 7489 7479 -10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claucambra kindly check my comments
shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m
Outdated
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m
Outdated
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m
Outdated
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m
Show resolved
Hide resolved
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…eived line start and end Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…crash Signed-off-by: Claudio Cambra <[email protected]>
…tories Signed-off-by: Claudio Cambra <[email protected]>
…rk with raw buffers Signed-off-by: Claudio Cambra <[email protected]>
b35e3d6
to
1e9dbf8
Compare
/backport to stable-3.9 |
AppImage file: nextcloud-PR-5903-1e9dbf8f14f12331cd065c9d2c37b5d9e67995b5-x86_64.AppImage |
Kudos, SonarCloud Quality Gate passed! |
The backport to stable-3.9 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-3.9
git pull origin stable-3.9
# Create the new backport branch
git checkout -b fix/foo-stable-3.9
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.9 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Backport attempt was a mistake, no need as file provider inclusion was reverted in stable-3.9 |
This PR fixes the broken Finder Sync Extension in master. Specifically:
Closes #5755