always propagate locked status to read-only or read/write for real file #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.9 |
8 tasks
mgallien
force-pushed
the
bugfix/lockedFileShouldBeReadOnly
branch
2 times, most recently
from
9de4574
to
fa18fa7
Compare
claucambra
approved these changes
Jul 3, 2023
mgallien
force-pushed
the
bugfix/lockedFileShouldBeReadOnly
branch
from
fa18fa7
to
3c893e5
Compare
mgallien
force-pushed
the
bugfix/lockedFileShouldBeReadOnly
branch
5 times, most recently
from
6d21c43
to
ffea7b3
Compare
make sure that a file locked that would not be modifiable by the current client is read-only on storage also make sure we make a file read/write when modification can happen again Close #5537 Signed-off-by: Matthieu Gallien <[email protected]>
should help investigate failure for automated tests Signed-off-by: Matthieu Gallien <[email protected]>
we try to preserve complex existing permissions unless the client is required to change them significantly Signed-off-by: Matthieu Gallien <[email protected]>
will fix behavior on windows by properly setting the new temp file just downloaded have the proper state (read only or read/write) and not the already existing file that will be replaced by the newly odwnloaded one Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/lockedFileShouldBeReadOnly
branch
from
ffea7b3
to
bc28bc4
Compare
|
AppImage file: nextcloud-PR-5841-bc28bc43c3fdd0fbc3b532aae4671e9a878df1af-x86_64.AppImage |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5841 +/- ##
==========================================
+ Coverage 60.08% 60.13% +0.05%
==========================================
Files 145 145
Lines 18711 18718 +7
==========================================
+ Hits 11242 11256 +14
+ Misses 7469 7462 -7
|
|
Kudos, SonarCloud Quality Gate passed! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that a file locked that would not be modifiable by the current client is read-only on storage
also make sure we make a file read/write when modification can happen again
Close #5537