fix failing tests by using FileSystem::setFileReadOnlyWeak

we try to preserve complex existing permissions unless the client is required to change them significantly Signed-off-by: Matthieu Gallien <[email protected]>
nextcloud · Jul 11, 2023 · ffea7b3 · ffea7b3
1 parent fd37c58
commit ffea7b3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/libsync/propagatedownload.cpp b/src/libsync/propagatedownload.cpp
@@ -1203,7 +1203,7 @@ void PropagateDownloadFile::downloadFinished()
         FileSystem::setFileReadOnly(filename, true);
     } else {
         qCDebug(lcPropagateDownload()) << "file is not locked: making it read write";
-        FileSystem::setFileReadOnly(filename, (!_item->_remotePerm.isNull() && !_item->_remotePerm.hasPermission(RemotePermissions::CanWrite)));
+        FileSystem::setFileReadOnlyWeak(filename, (!_item->_remotePerm.isNull() && !_item->_remotePerm.hasPermission(RemotePermissions::CanWrite)));
     }
 
     // Apply the remote permissions
@@ -1353,7 +1353,7 @@ void PropagateDownloadFile::updateMetadata(bool isConflict)
         FileSystem::setFileReadOnly(fn, true);
     } else {
         qCDebug(lcPropagateDownload()) << "file is not locked: making it read write";
-        FileSystem::setFileReadOnly(fn, (!_item->_remotePerm.isNull() && !_item->_remotePerm.hasPermission(RemotePermissions::CanWrite)));
+        FileSystem::setFileReadOnlyWeak(fn, (!_item->_remotePerm.isNull() && !_item->_remotePerm.hasPermission(RemotePermissions::CanWrite)));
     }
 
     qint64 duration = _stopwatch.elapsed();