Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step1 - GitHub(모듈 분리) #100

Merged
merged 4 commits into from
Aug 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Step1(2023-08-29) #
* [x] 순수 코틀린 모듈인 domain 모듈을 만든다.
* [x] 순수 코틀린 모듈인 data 모듈을 만든다.
* [x] data 모듈은 domain 모듈에 의존해야 한다.
* [x] app 모듈은 domain 모듈에 의존해야 한다.

2 changes: 2 additions & 0 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ android {
}

dependencies {
implementation(project(":domain"))

implementation("org.jetbrains.kotlin:kotlin-stdlib:${Version.kotlin}")
implementation("androidx.core:core-ktx:1.9.0")
implementation("androidx.appcompat:appcompat:1.6.0")
Expand Down
1 change: 1 addition & 0 deletions data/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
12 changes: 12 additions & 0 deletions data/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
plugins {
id("kotlin")
}

java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}

dependencies {
implementation(project(":domain"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 설정 옵션을 활성화하여 EOF 경고를 없애주세요 🙂

  • File > Preferences > Editor > General > Ensure every saved file ends with a line break

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알겠습니다!! 피드백 감사합니다~

4 changes: 4 additions & 0 deletions data/src/main/java/com/nextstep/edu/data/MyClass.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package com.nextstep.edu.data

class MyClass {
}
1 change: 1 addition & 0 deletions domain/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
8 changes: 8 additions & 0 deletions domain/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
plugins {
id("kotlin")
}

java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}
4 changes: 4 additions & 0 deletions domain/src/main/java/com/nextstep/edu/domain/MyClass.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package com.nextstep.edu.domain

class MyClass {
}
Comment on lines +3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 상황에서 .gitkeep파일을 만들어 관리하는 방법도 있으니 참고만 해주세요!
https://www.freecodecamp.org/news/what-is-gitkeep/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호!! 그렇군요!! 해당 내용도 살펴보도록 하겠습니다~ 감사합니다!

2 changes: 2 additions & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
include(":app")
rootProject.name = "android-github"
include(":domain")
include(":data")