Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step1 - GitHub(모듈 분리) #100

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

Gyuil-Hwnag
Copy link

@Gyuil-Hwnag Gyuil-Hwnag commented Aug 29, 2023

안녕하세요~ 리뷰어님
이번 미션 잘부탁드립니다🙇‍♂️

작업 내용

  1. domain 모듈 추가 [0283692]
  2. data 모듈 추가 & domain 모듈 의존성 추가 [3e8c2df]
  3. app 모듈에 domain 모듈 의존성 추가 [809513e]

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 규일님! 이번 미션을 함께하게 된 김수현입니다. 잘부탁드려요!
미션 구현을 잘 해주셨습니다 💯

조금 고민해보시면 좋을 내용을 코멘트로 달았으니 다음 단계 미션 진행해주시면서 같이 반영해주시면 됩니다!

다음 미션도 화이팅입니다 🙏


dependencies {
implementation(project(":domain"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 설정 옵션을 활성화하여 EOF 경고를 없애주세요 🙂

  • File > Preferences > Editor > General > Ensure every saved file ends with a line break

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알겠습니다!! 피드백 감사합니다~

Comment on lines +3 to +4
class MyClass {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 상황에서 .gitkeep파일을 만들어 관리하는 방법도 있으니 참고만 해주세요!
https://www.freecodecamp.org/news/what-is-gitkeep/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호!! 그렇군요!! 해당 내용도 살펴보도록 하겠습니다~ 감사합니다!

@wisemuji wisemuji merged commit 8b046bd into next-step:gyuil-hwnag Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants