Feature Reopen cookie notice #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmarz
reviewed
Jan 7, 2020
dist/scripts/cookie-consent.js
Outdated
| document.body.classList.add('has-cookie-consent'); | ||
| showCookieNotice(); | ||
| var button = document.querySelector('[data-trigger-cookie-consent]'); | ||
| console.log(button); |
There was a problem hiding this comment.
debug code should be removed 😬 I also wonder why it's added in the dist script only 🤔 maybe added manually?
fabianmarz
reviewed
Jan 7, 2020
| @@ -3,21 +3,34 @@ | |||
| return; | |||
| } | |||
|
|
|||
| function addCookieSettingsButton() { | |||
There was a problem hiding this comment.
The function name is misleading as this function doesn't actually add a button but registers the click handler for it. IMO this doesn't necessarily needs to be in a dedicated function as it's invoked once. But we can leave it to move forward 👍
There was a problem hiding this comment.
referenced in issue and created a ticket for it to fast forward. #51
fabianmarz
approved these changes
Jan 8, 2020
…when in hidden state.
andreasblumberg
deleted the
feature/reopen-cookie-notice-1154380372326297-andreas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description