Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addCookieSettingsButton() function name is misleading #51

Open
andreasblumberg opened this issue Jan 8, 2020 · 0 comments
Open

addCookieSettingsButton() function name is misleading #51

andreasblumberg opened this issue Jan 8, 2020 · 0 comments
Assignees
@fabianmarz

Comments

@andreasblumberg
Copy link
Contributor

andreasblumberg commented Jan 8, 2020 •
edited by sun 

  function addCookieSettingsButton() {

The function name is misleading as this function doesn't actually add a button but registers the click handler for it. IMO this doesn't necessarily needs to be in a dedicated function as it's invoked once. But we can leave it to move forward 👍

Originally posted by @fabianmarz in #50
@andreasblumberg andreasblumberg mentioned this issue Jan 8, 2020
Merged
@sun sun changed the title function name is misleading addCookieSettingsButton() function name is misleading Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianmarz fabianmarz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabianmarz @andreasblumberg