-
-
Notifications
You must be signed in to change notification settings - Fork 50
Add clean up of previous images #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
netbrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, we really need some housekeeping.
However need to robustify the script a bit, and i think there's some mix of indentation usage (spaces). See comments.
|
Another thing, the dont_clean option should also be present in flake.nix |
|
@danieldean The zwift.sh script was moved to a src directory in #272, so you need to rebase your branch before these changes can be merged ( |
Thanks and noted. At the moment I think the array splitting is a blocker so will resolve that first if possible then rebase. |
|
Ok... hopefully all issues resolved and all good now with the rebase. Bash is deceptively complicated! |
netbrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this, i think it looks ok,
|
Ok, further suggested changes applied. Hope all is good now? I know some more Bash that I did to start with... |
Co-authored-by: Glenn <[email protected]>
|
Merging as is, it's fine. |
This is a contribution for #273. Let me know if there are any issues!
All tests passed apart from doc building. It works when running for me and cleans up as expected.