Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): flaky durable provider, remove instance on error #14133

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Nov 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #13953 #11664

What is the new behavior?

PR based off #11666 + updated unit tests, added integration test, resolved conflits

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8f55836b-6518-482c-bd57-308533d232a4

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.224%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/injector.ts 0 1 0.0%
packages/core/injector/instance-wrapper.ts 6 7 85.71%
Totals Coverage Status
Change from base Build 72f148bc-4145-44b3-a3c4-06a616307114: -0.02%
Covered Lines: 6760
Relevant Lines: 7330

💛 - Coveralls

Copy link

@Vue-Pu Vue-Pu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'fix/flaky-durable-provider'

@kamilmysliwiec kamilmysliwiec merged commit 831d295 into master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants