Durable providers are unable to recover from errors being thrown

[dberardo-com]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

the issue is described here and it is still relevant: #11664

Minimum reproduction code

check here: #11664

Steps to reproduce

No response

Expected behavior

durable provider should be decached and retried next time.

it would be nice if this is the default behavior even after the creation of the provider, i.e. in case of exceptions along its life

Package

• I don't know. Or some 3rd-party package
• @nestjs/common
• @nestjs/core
• @nestjs/microservices
• @nestjs/platform-express
• @nestjs/platform-fastify
• @nestjs/platform-socket.io
• @nestjs/platform-ws
• @nestjs/testing
• @nestjs/websockets
• Other (see below)

Other package

No response

NestJS version

10.1.3

Packages versions

  "@nestjs/typeorm": "^10.0.0",

Node.js version

16

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[micalevisk]

here's a minimum reproduction of this: https://gitlab.com/micalevisk/nestjs-issue-11664

[dberardo-com]

hope this gets some visibility soon, it is kind of a major bug indeed.

@micalevisk which versione of nestjs are you using? i havent tried the latest yet, dont know if the bug was perhaps fixed there (i am on 10.1 i guess)

[dberardo-com]

btw, i have tested the patch in this PR: https://github.com/nestjs/nest/pull/11666/files and it seems to work, although it never made it to upstream ...

if you know how to use use patch-package (https://dev.to/zhnedyalkow/the-easiest-way-to-patch-your-npm-package-4ece), you only need this patch file and durable providers will be decached on errors:

@nestjs+core+10.3.3.patch

diff --git a/node_modules/@nestjs/core/injector/injector.js b/node_modules/@nestjs/core/injector/injector.js
index 53b1d5f..47f5741 100644
--- a/node_modules/@nestjs/core/injector/injector.js
+++ b/node_modules/@nestjs/core/injector/injector.js
@@ -70,6 +70,12 @@ class Injector {
             await this.resolveConstructorParams(wrapper, moduleRef, inject, callback, contextId, wrapper, inquirer);
         }
         catch (err) {
+            // https://github.com/nestjs/nest/pull/11666/files
+            console.error("[@nestjs/core/injector.js] - error on init of", contextId, err)
+            wrapper.removeInstanceByContextId(
+                this.getContextId(contextId, wrapper),
+                inquirerId,
+            );
             settlementSignal.error(err);
             throw err;
         }
diff --git a/node_modules/@nestjs/core/injector/instance-wrapper.js b/node_modules/@nestjs/core/injector/instance-wrapper.js
index 2f15b02..5bb87f1 100644
--- a/node_modules/@nestjs/core/injector/instance-wrapper.js
+++ b/node_modules/@nestjs/core/injector/instance-wrapper.js
@@ -75,6 +75,24 @@ class InstanceWrapper {
         }
         collection.set(contextId, value);
     }
+    // https://github.com/nestjs/nest/pull/11666/files
+    removeInstanceByContextId(contextId, inquirerId) {
+        console.error("[@nestjs/core/instance-wrapper.js] - removing context", contextId, inquirerId)
+        if (this.scope === common_1.Scope.TRANSIENT && inquirerId) {
+            return this.removeInstanceByInquirerId(contextId, inquirerId);
+        }
+
+        this.values.delete(contextId);
+    }
+
+    removeInstanceByInquirerId(contextId, inquirerId) {
+        let collection = this.transientMap.get(inquirerId);
+        if (!collection) {
+            return;
+        }
+
+        collection.delete(contextId);
+    }
     addCtorMetadata(index, wrapper) {
         if (!this[exports.INSTANCE_METADATA_SYMBOL].dependencies) {
             this[exports.INSTANCE_METADATA_SYMBOL].dependencies = [];

[kamilmysliwiec]

Let's track this here #14133