Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backport cms 4.0.x - Django 3.2 with Python 3.8 & 3.9 support, including update tooling #70

Open
wants to merge 20 commits into
base: support/4.0.x
Choose a base branch
from

Conversation

Aiky30
Copy link

@Aiky30 Aiky30 commented Dec 21, 2021

Description

Describe:

  • Ported changes made in the main branch to the cms v4 supported branch.
  • Removed all py2 # -- coding: utf-8 --
  • Removed six imports
  • Removed __future__ declaration
  • Removed @python_2_unicode_compatible
  • replaced ugettext with gettext, ugettext_lazy with gettext_lazy, and ungettext with ngettext
  • replaced force_text() with force_str(), https://docs.djangoproject.com/en/3.2/ref/utils/#django.utils.encoding.force_text
  • moved from django.conf.urls.url() to django.urls.re_path()

References

Changes ported from: 05c93d5

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@Aiky30 Aiky30 changed the title feat: Backport cms 4.0.x - update tooling feat: Backport cms 4.0.x - Django 3.2 with Python 3.8 & 3.9 support, including update tooling Dec 21, 2021
@coveralls
Copy link

coveralls commented Dec 22, 2021

Coverage Status

Coverage increased (+95.5%) to 95.506% when pulling 774ff10 on Aiky30:feature/cms4-support-update-tooling into 9846374 on nephila:support/4.0.x.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (support/4.0.x@9846374). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 774ff10 differs from pull request most recent head acc9942. Consider uploading reports for the commit acc9942 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##             support/4.0.x      #70   +/-   ##
================================================
  Coverage                 ?   94.44%           
================================================
  Files                    ?        8           
  Lines                    ?      180           
  Branches                 ?       22           
================================================
  Hits                     ?      170           
  Misses                   ?        8           
  Partials                 ?        2           
Flag Coverage Δ
unittests 94.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9846374...acc9942. Read the comment docs.

@joshyu
Copy link

joshyu commented Mar 12, 2024

Hi @Aiky30 ,
Is this PR still in progress?
I want to add Django4.2 support based on your PR.

@Aiky30
Copy link
Author

Aiky30 commented Mar 13, 2024

Hi @joshyu,

Sadly this was never accepted by Nephila. This is potentially an issue because any changes that you make would only compound the sheer amount of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants