Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backport cms 4.0.x - Django 3.2 with Python 3.8 & 3.9 support, including update tooling #77

Closed
wants to merge 47 commits into from

Conversation

yakky
Copy link
Member

@yakky yakky commented Aug 27, 2022

Description

Merge code from #70 with updated develop

References

Fix #70

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

yakky and others added 30 commits May 2, 2020 22:28
* Compatibility with Django-CMS 3.7.2

Co-authored-by: Fabrice Pardo <[email protected]>
* Bump develop version [ci skip]
* Remove useless try/except as it is an old syntax
* Fix HISTORY.rst syntax
* Remove leftovers from template project

Co-authored-by: Iacopo Spalletti <[email protected]>
* Add support for django-app-enabler

* Update readme

* Update dependencies
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (support/4.0.x@3f099fc). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             support/4.0.x      #77   +/-   ##
================================================
  Coverage                 ?   94.56%           
================================================
  Files                    ?        9           
  Lines                    ?      184           
  Branches                 ?       22           
================================================
  Hits                     ?      174           
  Misses                   ?        7           
  Partials                 ?        3           
Flag Coverage Δ
unittests 94.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Aug 27, 2022

Coverage Status

Coverage increased (+96.2%) to 96.154% when pulling 7c3c42c on feature/issue-74-update-django-cms4 into 9846374 on support/4.0.x.

@yakky
Copy link
Member Author

yakky commented Aug 27, 2022

@Aiky30 can you review this port of #70? I have merged with latest update from develop to make sure the two branches don't drift apart

I'll make a release to divio cloud with the current state of this branch and a beta one after merge

Copy link

@Aiky30 Aiky30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only minor thing is the pinning of djangocms-verisoning. I updated the authors file but that could be auto populated so may undo any changes.

Also, great to have you back around @yakky, we genuinely missed you man.


Development Lead
----------------

* Iacopo Spalletti <i.spalletti@nephila.it>
* Iacopo Spalletti <i.spalletti@nephila.digital>

Contributors
------------

* Anton Egorov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is auto populated.

Suggested change
* Anton Egorov
* Aiky30
* Anton Egorov

@@ -3,3 +3,4 @@ coveralls
flake8>=2.1.0
tox>=2.0
django-app-helper
https://github.com/Aiky30/djangocms-versioning/tarball/feature/django-32-compat#egg=djangocms-versioning
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://github.com/Aiky30/djangocms-versioning/tarball/feature/django-32-compat#egg=djangocms-versioning
https://github.com/django-cms/djangocms-versioning/tarball/master#egg=djangocms-versioning

This was an old pin before 3.2 changes were merged.

@yakky
Copy link
Member Author

yakky commented May 12, 2023

Replaced by #83 which includes the whole set of django CMS 4 changes

@yakky yakky closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants