remove digital ocean tests #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-D-Lewis
reviewed
Nov 4, 2024
tests/tests_unit/test_upgrade.py
Outdated
|
|
||
| __rounded_version__ = rounded_ver_parse(__version__) | ||
|
|
||
| # Check image versions have been bumped up |
There was a problem hiding this comment.
I think there's value in keeping this sort of check that the versions have been updated in the nebari config.
Adam-D-Lewis
reviewed
Nov 4, 2024
tests/tests_unit/test_upgrade.py
Outdated
| version = version_str | ||
|
|
||
|
|
||
| def test_duplicated_version(new_upgrade_cls): |
There was a problem hiding this comment.
I think this is a good test to have also
Adam-D-Lewis
requested changes
Nov 4, 2024
Adam-D-Lewis
reviewed
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Removes failing digital ocean tests since we are depercating DO
What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
See if CI passes
Any other comments?