-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility prompt and notes for shared group mounting #2739
Conversation
For the failling tests, I think the our keycloak module when imported ends up initializing a connection by default with the keycloak server, which leads to issues. Will address these soon |
612574d
to
329e902
Compare
I found the root issue. In the affected tests, we have a whitelist of prompt messages and their expected responses. If the prompt is not added there, it defaults to |
src/_nebari/upgrade.py
Outdated
|
||
text = textwrap.dedent( | ||
""" | ||
Nebari version [green]2024.9.1[/green] introduces changes to how group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could use a little more detail explaining exactly what's going on here and specifying that the two options here are either all groups or just admin/analyst/developer. Suggested rewording below (please review for accuracy as well as grammar!)
Nebari version [green]2024.9.1[/green] introduces changes to how group directories are mounted in JupyterLab pods.
In previous versions of Nebari, every Keycloak group in the Nebari realm initiated the creation of a shared file directory that all group members could access in their JupyterLab pod at ~/shared/[group-name]
.
As of Nebari version [green]2024.9.1[/green], only groups that are assigned the jupyterhub
Client Role allow-group-directory-creation
will
You will be asked to confirm whether Nebari should now assign this role to all of your current groups. If not, only the admin
, analyst
, and developer
group directories will be mounted in JupyterHub pods.
Regardless of your choice now, no data will be lost during this operation. You can re-mount group directories at any time by adding or removing the allow-group-directory-creation-role
from your groups in the Keycloak UI.
For more information, please see the [green][link=https://www.nebari.dev/docs/how-tos/group-directory-creation]documentation[/link][/green].
src/_nebari/upgrade.py
Outdated
rich.print(text) | ||
|
||
confirm = Prompt.ask( | ||
"[bold]Would you like Nebari to update your group permissions now?[/bold]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are clear with what the feature is actually doing in the intro text, then I think we can change this to:
Would you like Nebari to assign allow-group-directory-creation-role
to all of your groups now?
Reference Issues or PRs
closes #2736
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Any other comments?