Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Update upgrade prompt regarding shared group mounting #2736

Closed
viniciusdc opened this issue Sep 24, 2024 · 1 comment · Fixed by #2739
Closed

[ENH] - Update upgrade prompt regarding shared group mounting #2736

viniciusdc opened this issue Sep 24, 2024 · 1 comment · Fixed by #2739
Labels
type: enhancement 💅🏼 New feature or request

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Sep 24, 2024

Context

After merging PR #2593, any user groups besides admin, analyst, and develop have been unmounted from users' JupyterLab pods. While no data has been removed, this change breaks compatibility with existing deployments that rely on these custom groups.

  • Include a prompt during the upgrade process to inform users about this change and guide them on how to manage their custom groups.
  • Add detailed release notes about this change, allowing users to opt into the new role addition for existing groups.

Value and/or benefit

  • backwards compatibility

Anything else?

No response

@viniciusdc viniciusdc added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Sep 24, 2024
@viniciusdc viniciusdc changed the title [ENH] - Update upgrade prompt reggarding shared group mounting [ENH] - Update upgrade prompt regarding shared group mounting Sep 24, 2024
@viniciusdc
Copy link
Contributor Author

The prompt will then ask the admin user running the upgrade if they want to include the missing role (bellow) to all existing groups to avoid the "removal" during the re-deployment. A message saying that it this is not an actual removal of data and can be rollebacked anytime from within the keycloak console should also be presented to provide context.

allow-group-directory-creation-role:
   component: shared-directory
   scopes: write:shared

@viniciusdc viniciusdc mentioned this issue Sep 24, 2024
29 tasks
@Adam-D-Lewis Adam-D-Lewis added type: enhancement 💅🏼 New feature or request and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Sep 24, 2024
@viniciusdc viniciusdc linked a pull request Sep 24, 2024 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants