Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix incorrect config override #2086 #2087

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 24, 2023

Reference Issues or PRs

close #2086
xref #2064

the bug was introduced in #2056

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@fangchenli fangchenli added the type: bug 🐛 Something isn't working label Oct 24, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli!

@iameskild iameskild merged commit b254cc8 into nebari-dev:develop Oct 24, 2023
10 checks passed
@fangchenli fangchenli mentioned this pull request Oct 29, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
2 participants