Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: migrate to Pydantic 2 #1928

Closed
wants to merge 96 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Aug 23, 2023

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@fangchenli
Copy link
Member Author

Hey @fangchenli, how much more work do you think is involved in getting this PR ready for review? Currently only the Test Conda Build is failing. Is that the only thing that needs to be fixed?

Yes, the conda build test is the only thing left. It's unclear why it's failing. My plan is to split this PR and move some of the refactoring and cleanups to separate PRs.

@pavithraes pavithraes removed this from the The Release After Next milestone Dec 19, 2023
fangchenli added a commit to fangchenli/nebari that referenced this pull request Feb 14, 2024
@dcmcand dcmcand added status: stale 🥖 Not up to date with the default branch - needs update Close? Issues which may be closable unless discussion continued and removed status: in progress 🏗 This task is currently being worked on labels Mar 13, 2024
@Adam-D-Lewis
Copy link
Member

I'd like to take this over

@Adam-D-Lewis Adam-D-Lewis removed status: stale 🥖 Not up to date with the default branch - needs update Close? Issues which may be closable unless discussion continued labels Mar 19, 2024
@Adam-D-Lewis
Copy link
Member

@fangchenli Thanks for your work on this! It looks great. Since your internship has ended, I'll assume you moved on to other things (but let me know if I'm wrong if you'd like to continue working on this), but I'd like to get this into Nebari. I'm going to close this PR and create a new one so I can commit to the working branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

6 participants