Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RELEASE notes, minor fixes #2039

Merged
merged 20 commits into from
Oct 21, 2023
Merged

Update RELEASE notes, minor fixes #2039

merged 20 commits into from
Oct 21, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Sep 28, 2023 •
edited
Loading

Reference Issues or PRs

closes #2037
closes #2058
closes #2081

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added the area: documentation 📖 Improvements or additions to documentation label Sep 28, 2023
@iameskild iameskild added this to the Release 2023.9.1 milestone Sep 28, 2023
@fangchenli
Copy link
Member

The CI failures are unrelated. I'm seeing those in all my recent PRs.

fangchenli
fangchenli suggested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@fangchenli fangchenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nebari/src/nebari/schema.py

Lines 89 to 90 in 056b420

if len(project_name) > 16:
project_name = project_name[:16]

This can be removed.

@pavithraes pavithraes self-requested a review October 6, 2023 14:35
sblair-metrostar
sblair-metrostar reviewed Oct 6, 2023
View reviewed changes
README.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@iameskild iameskild mentioned this pull request Oct 10, 2023
Closed
fangchenli
fangchenli reviewed Oct 19, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@iameskild iameskild mentioned this pull request Oct 20, 2023
Closed
@iameskild iameskild merged commit 376ffba into develop Oct 21, 2023
28 checks passed
@iameskild iameskild deleted the 20230927eae branch October 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblair-metrostar sblair-metrostar sblair-metrostar left review comments

@kenafoster kenafoster kenafoster approved these changes

@fangchenli fangchenli fangchenli approved these changes

@pavithraes pavithraes Awaiting requested review from pavithraes

Assignees
No one assigned
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.10.1
4 participants
@iameskild @fangchenli @kenafoster @sblair-metrostar