Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Incorrect format for Gitops repo_url in init.py (http instead of https). #2058

Closed
biztos opened this issue Oct 10, 2023 · 1 comment · Fixed by #2039
Closed

[BUG] - Incorrect format for Gitops repo_url in init.py (http instead of https). #2058

biztos opened this issue Oct 10, 2023 · 1 comment · Fixed by #2039
Labels
area: nebari-cli type: bug 🐛 Something isn't working
Milestone

Comments

@biztos
Copy link

biztos commented Oct 10, 2023

Describe the bug

The following line defines a format for the Gitops repo URL which is incorrect and fails validation when assigned to inputs.repository:

repo_url = "http://{git_provider}/{org_name}/{repo_name}"

This causes Guided Init to fail if Gitops is selected. Changing the format to use https instead of http appears to fix this.

NOTE: the Guided Init help text also incorrectly refers to http instead of https.

Expected behavior

The constructed URL should be valid and initialization should complete.

OS and architecture in which you are running Nebari

macOS 13.5.2 (22G91) (M1)

How to Reproduce the problem?

  1. nebari init --guided-init
  2. Give valid responses to prompts.
  3. Choose Y for Gitops.
  4. Give valid responses to prompts.
  5. Observe Python ValidationError.

Command output

No response

Versions and dependencies used.

nebari version 2023.9.1rc2.dev1+g056b420

Compute environment

None

Integrations

No response

Anything else?

No response

@biztos biztos added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Oct 10, 2023
@iameskild
Copy link
Member

Hi @biztos! Thanks for sharing this with us. I believe there is an open PR with this fix 💪

@iameskild iameskild added area: nebari-cli and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Oct 16, 2023
@pavithraes pavithraes moved this from New 🚦 to In progress 🏗 in 🪴 Nebari Project Management Oct 16, 2023
@iameskild iameskild added this to the The Next Release milestone Oct 20, 2023
@github-project-automation github-project-automation bot moved this from In progress 🏗 to Done 💪🏾 in 🪴 Nebari Project Management Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nebari-cli type: bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants