-
Notifications
You must be signed in to change notification settings - Fork 125
[nasa/nos3#550] code formatter #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #568 +/- ##
==========================================
+ Coverage 72.77% 72.82% +0.05%
==========================================
Files 744 745 +1
Lines 91191 91497 +306
Branches 6923 6942 +19
==========================================
+ Hits 66362 66636 +274
- Misses 24829 24861 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All Submissions:
New Feature Submissions:
Changes to Core Features:
How to test these changes?
Closing Tags
|
The auto-commit of a linter will cause the "Checks Passed" portion of the PR to fall off if there are linter changes that are automatically changed. We've decided that this trade-off is worth it for the automated linting. Users can still click the workflow circles next to their commits to view these checks, rather than them showing up automatically. |
Not a big deal for this work, but reminder that merge into dev for each submodule should happen after a PR like this is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As submodules were already merged into dev
those pieces were integrated already while closing prior merge requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, tested nos things look ok
# Conflicts: # components/arducam # components/generic_adcs # components/generic_css # components/generic_eps # components/generic_imu # components/generic_mag # components/generic_radio # components/generic_star_tracker # components/generic_thruster # components/generic_torquer # components/novatel_oem615 # components/sample
Added linter.yml file into the .github/workflows/linter.yml directory for every component submodule and merged all into dev