ROS2 mobility: (part of) planner_qp #733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marinagmoreira not sure if you are going to be involved in the ROS2 port, but I realized that this PR was still waiting feedback. Also tagging @bcoltin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a PR for the planner_qp package for the ROS2 conversion. Deliberately, it does not include planner_qp itself, as I first wanted to check this in and gather any feedback.
For reference, this PR therefore includes
@marinagmoreira
In traj_opt_ros, I separated the nh_ and the pub map, into one for Trajectory and SolverInfo, as it seems ROS2 does not allow the implementation that ROS1 allows. The code does seem to allow this change, based on the
getPub,getInfoPub, and the other methods were already explicit.Cheers,
Joris