Skip to content

MIDI import: don't round tempo #30586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −18
Open

MIDI import: don't round tempo #30586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb05100
MIDI import: don't round tempo
cbjeukendrup Oct 17, 2025
b74a208
Update midi import test
mathesoncalum Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions src/importexport/midi/internal/midiimport/importmidi_tempo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,39 +78,28 @@ void setTempoToScore(Score* score, int tick, double beatsPerSecond)

auto* data = midiImportOperations.data();
if (data->trackOpers.showTempoText.value()) {
const int tempoInBpm = qRound(beatsPerSecond * 60.0);

Measure* measure = score->tick2measure(Fraction::fromTicks(tick));
if (!measure) {
LOGD("MidiTempo::setTempoToScore: no measure for tick %d", tick);
return;
}
Segment* segment = measure->getSegment(SegmentType::ChordRest, Fraction::fromTicks(tick));
if (!segment) {
LOGD("MidiTempo::setTempoToScore: no chord/rest segment for tempo at %d", tick);
return;
}
Segment* segment = measure->getChordRestOrTimeTickSegment(Fraction::fromTicks(tick));

TempoText* tempoText = mu::engraving::Factory::createTempoText(segment);
tempoText->setTempo(beatsPerSecond);
tempoText->setXmlText(QString("<sym>metNoteQuarterUp</sym> = %1").arg(tempoInBpm));
tempoText->setXmlText(String(u"<sym>metNoteQuarterUp</sym> = %1").arg(beatsPerSecond * 60.0));
tempoText->setTrack(0);
segment->add(tempoText);
data->hasTempoText = true; // to show tempo text column in the MIDI import panel
}
}

double roundToBpm(double beatsPerSecond)
{
return qRound(beatsPerSecond * 60.0) / 60.0;
}

void applyAllTempoEvents(const std::multimap<int, MTrack>& tracks, Score* score)
{
for (const auto& track: tracks) {
if (track.second.isDivisionInTps) { // ticks per second
const double ticksPerBeat = Constants::DIVISION;
const double beatsPerSecond = roundToBpm(track.second.division / ticksPerBeat);
const double beatsPerSecond = track.second.division / ticksPerBeat;
setTempoToScore(score, 0, beatsPerSecond);
} else { // beats per second
for (const auto& ie : track.second.mtrack->events()) {
Expand All @@ -120,7 +109,7 @@ void applyAllTempoEvents(const std::multimap<int, MTrack>& tracks, Score* score)
ie.first, track.second.division, false);
const uchar* data = (uchar*)e.edata();
const unsigned tempo = data[2] + (data[1] << 8) + (data[0] << 16);
const double beatsPerSecond = roundToBpm(1000000.0 / tempo);
const double beatsPerSecond = 1000000.0 / tempo;
setTempoToScore(score, tick.ticks(), beatsPerSecond);
}
}
Expand Down Expand Up @@ -164,7 +153,7 @@ void setTempo(const std::multimap<int, MTrack>& tracks, Score* score)
averageTempoFactor /= counter;

const double basicTempo = MidiTempo::findBasicTempo(tracks, true);
const double tempo = roundToBpm(basicTempo * averageTempoFactor);
const double tempo = basicTempo * averageTempoFactor;

score->tempomap()->clear(); // use only one tempo marking for all score
setTempoToScore(score, 0, tempo);
Expand Down
4 changes: 2 additions & 2 deletions src/importexport/midi/tests/midiimport_data/human_tempo-ref.mscx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@
<sigD>4</sigD>
</TimeSig>
<Tempo>
<tempo>2.2</tempo>
<tempo>2.19233</tempo>
<eid>G_G</eid>
<text><sym>metNoteQuarterUp</sym> = 132</text>
<text><sym>metNoteQuarterUp</sym> = 131.539816</text>
</Tempo>
<Rest>
<eid>H_H</eid>
Expand Down
Loading