MIDI import: don't round tempo #30586
Open
+7
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: musescore#14349 Closes musescore#15115 Co-authored-by: shachiang428 <[email protected]>
cbjeukendrup
force-pushed
the
midi_import_dont_round_tempo
branch
from
ee42cb6 to
bb05100
Compare
|
This probably isn't a dealbreaker, but I made a MIDI file in logic with the tempo 77.66666 (which may have rounded in Logic to 77.6667), opened it in this PR, and the displayed tempo in the score for some reason is 77.666686 Properties cuts the decimal off to 2 places, which I think is fine (this is the true tempo anyway, right?): Using 77.33333 didn't do anything noticeably strange like this. |
mathesoncalum
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #14349
Closes #15115