Skip to content

Rearrange chord symbols capitalization options #30544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2025
Merged

Rearrange chord symbols capitalization options #30544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c709b3b
Rearrange chord symbols capitalization options
SilverGreen93 Oct 15, 2025
3277bd6
Fix wrong indentation
SilverGreen93 Oct 16, 2025
68808e5
Rework layout with StyleToggle
SilverGreen93 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 51 additions & 42 deletions src/notation/qml/MuseScore/NotationScene/internal/EditStyle/ChordSymbolsPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,27 +169,27 @@ StyledFlickable {
title: qsTrc("notation/editstyle/chordsymbols", "Spelling")

RowLayout {
spacing: 6
spacing: 12
anchors.fill: parent

RadioButtonGroup {
id: spellingRadioButtonGroup
Layout.fillWidth: true
model: chordSymbolsModel.possibleChordSymbolSpellings()
ButtonGroup { id: spellingButtonGroup }

Repeater {
model: chordSymbolsModel.possibleChordSymbolSpellings()
delegate: RoundedRadioButton {
height: 30
checked: modelData.value === chordSymbolsModel.chordSymbolSpelling.value
text: modelData.text ? modelData.text : ""

onToggled: {
chordSymbolsModel.chordSymbolSpelling.value = modelData.value
}
ButtonGroup.group: spellingButtonGroup
Layout.alignment: Qt.AlignVCenter
}
}

FlatButton {
Layout.alignment: Qt.AlignTop | Qt.AlignRight
Layout.alignment: Qt.AlignVCenter
icon: IconCode.UNDO
enabled: !chordSymbolsModel.chordSymbolSpelling.isDefault
onClicked: chordSymbolsModel.chordSymbolSpelling.value = chordSymbolsModel.chordSymbolSpelling.defaultValue
Expand All @@ -198,48 +198,57 @@ StyledFlickable {
}

StyledGroupBox {
Layout.fillWidth: true
title: qsTrc("notation/editstyle/chordsymbols", "Capitalization")

label: CheckBox {
id: capitaliseCheckBox
text: qsTrc("notation/editstyle/chordsymbols", "Automatically capitalize note names")

checked: chordSymbolsModel.automaticCapitalization && Boolean(chordSymbolsModel.automaticCapitalization.value)
onClicked: {
if (chordSymbolsModel.automaticCapitalization) {
chordSymbolsModel.automaticCapitalization.value = !checked
}
}
}
ColumnLayout {
spacing: 12
Layout.fillWidth: true

Layout.fillWidth: true
RowLayout {
spacing: 8
Layout.fillWidth: true

RowLayout {
spacing: 6
anchors.fill: parent
StyleToggle {
Layout.preferredWidth: 460
styleItem: chordSymbolsModel.automaticCapitalization
text: qsTrc("notation/editstyle/chordsymbols", "Automatically capitalize note names")
}

CheckBox {
text: qsTrc("notation/editstyle/chordsymbols", "Lowercase minor chords")
checked: chordSymbolsModel.lowerCaseMinorChords.value === true
onClicked: chordSymbolsModel.lowerCaseMinorChords.value = !chordSymbolsModel.lowerCaseMinorChords.value
FlatButton {
Layout.alignment: Qt.AlignTop | Qt.AlignRight
icon: IconCode.UNDO
enabled: isResetEnabled(root.capitalizationStyles)
onClicked: resetStyles(root.capitalizationStyles)
}
}

CheckBox {
text: qsTrc("notation/editstyle/chordsymbols", "Lowercase bass notes")
checked: chordSymbolsModel.lowerCaseBassNotes.value === true
onClicked: chordSymbolsModel.lowerCaseBassNotes.value = !chordSymbolsModel.lowerCaseBassNotes.value
}
ColumnLayout {
spacing: 8
Layout.fillWidth: true

CheckBox {
text: qsTrc("notation/editstyle/chordsymbols", "All caps note names")
checked: chordSymbolsModel.allCapsNoteNames.value === true
onClicked: chordSymbolsModel.allCapsNoteNames.value = !chordSymbolsModel.allCapsNoteNames.value
}
CheckBox {
text: qsTrc("notation/editstyle/chordsymbols", "Lowercase minor chords")
checked: chordSymbolsModel.lowerCaseMinorChords.value === true
enabled: chordSymbolsModel.automaticCapitalization.value === true
onClicked: chordSymbolsModel.lowerCaseMinorChords.value = !chordSymbolsModel.lowerCaseMinorChords.value
}

FlatButton {
Layout.alignment: Qt.AlignTop | Qt.AlignRight
icon: IconCode.UNDO
enabled: isResetEnabled(root.capitalizationStyles)
onClicked: resetStyles(root.capitalizationStyles)
CheckBox {
text: qsTrc("notation/editstyle/chordsymbols", "Lowercase bass notes")
checked: chordSymbolsModel.lowerCaseBassNotes.value === true
enabled: chordSymbolsModel.automaticCapitalization.value === true
onClicked: chordSymbolsModel.lowerCaseBassNotes.value = !chordSymbolsModel.lowerCaseBassNotes.value
}

CheckBox {
text: qsTrc("notation/editstyle/chordsymbols", "All caps (for Solfeggio and French)")
checked: chordSymbolsModel.allCapsNoteNames.value === true
enabled: chordSymbolsModel.automaticCapitalization.value === true &&
(chordSymbolsModel.chordSymbolSpelling.value === 3 ||
chordSymbolsModel.chordSymbolSpelling.value === 4)
onClicked: chordSymbolsModel.allCapsNoteNames.value = !chordSymbolsModel.allCapsNoteNames.value
}
}
}
}
Expand Down Expand Up @@ -597,7 +606,7 @@ StyledFlickable {
Layout.fillWidth: true

Item {
Layout.preferredWidth: 452
Layout.preferredWidth: 480
implicitHeight: children.length === 1 ? children[0].implicitHeight : 0

CheckBox {
Expand Down
Loading