Skip to content

Conversation

SilverGreen93
Copy link
Contributor

@SilverGreen93 SilverGreen93 commented Oct 15, 2025

Resolves: #30539

Rearrange the capitalization options such that they have more space for non-English languages to fit.

image
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@bkunda
Copy link

bkunda commented Oct 16, 2025

Going to pass this over to @avvvvve for review. There's an interaction design quirk here, which is that the previous parent checkbox is now nested in with the children checkboxes. Perhaps it's a case of needing to replace it with a toggle switch, but I'll leave it with Ben to advise on the best approach.

I quite like the vertical arrangement of options though. Looks much neater than what was there before.

@bkunda bkunda requested a review from avvvvve October 16, 2025 09:29
@SilverGreen93
Copy link
Contributor Author

There's an interaction design quirk here, which is that the previous parent checkbox is now nested in with the children checkboxes. Perhaps it's a case of needing to replace it with a toggle switch, but I'll leave it with Ben to advise on the best approach.

In the original behaviour, the "children" checkboxes were working independently of the "parent" checkbox, i.e. they were clickable even if the "parent" was turned off. That was the main reason I grouped all 4 together and added a sepratate title for the whole group.

If the intention was to disable the 3 checkboxes below if the first one is unchecked, we should create that dependency then and maybe, as you said, replace the first with a toggle switch to be more intuitive.

@avvvvve
Copy link

avvvvve commented Oct 16, 2025

Yes, let's go ahead and use a toggle, and when it's turned off, disable the nested checkboxes. As far as I can tell, the nested 3 options already have no effect when changed if 'Automatically capitalize...' is turned off.

One more thing though. 'All caps note names' is a bit misleading—as far as I can tell, it only does something if you've selected Solfeggio or French as the spelling. If someone can verify that is has no effect for Standard/German/Full German in the codebase, I think we should also disable that checkbox when one of those is selected, and retitle it to 'All caps (for Solfeggio and French)'.

I'd still leave it grouped with the other checkboxes, because it can be used in conjunction with 'Lowercase minor chords' (even if this doesn't really have a practical application).

So to summarize + a quick design spec:

  • Make the parent 'Automatically capitalize...' option a toggle
  • Disable all nested checkboxes when the above is off
  • Retitle 'All caps note names' to 'All caps (for Solfeggio and French)', and disable it when 'Spelling' above is set to Standar, German, or Full German
  • Make the reset button part of the whole section including the toggle
  • Bonus: Change the padding between the radio buttons in the 'Spelling' section to 12px
image

And here's a quick video showing the existing behaviors described above:

Screen.Recording.2025-10-16.at.4.32.51.PM.mov

@cbjeukendrup
Copy link
Member

@SilverGreen93 Re making it a toggle, it would be convenient to wait with that until #30561 is merged, because that gives the ToggleButton component the same interface as CheckBox (and, waiting would avoid a conflict).

@cbjeukendrup
Copy link
Member

Update: that one is merged, so you can rebase and go ahead

Resolves: musescore#30539

Rearrange the capitalization options such that they have more space for non-English languages to fit.
@avvvvve
Copy link

avvvvve commented Oct 17, 2025

Much improved, good to go from the UI perspective!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chord symbols case options crowded in non-English languages

4 participants