-
Notifications
You must be signed in to change notification settings - Fork 3k
Rearrange chord symbols capitalization options #30544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Going to pass this over to @avvvvve for review. There's an interaction design quirk here, which is that the previous parent checkbox is now nested in with the children checkboxes. Perhaps it's a case of needing to replace it with a toggle switch, but I'll leave it with Ben to advise on the best approach. I quite like the vertical arrangement of options though. Looks much neater than what was there before. |
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/ChordSymbolsPage.qml
Outdated
Show resolved
Hide resolved
0955473
to
7975caf
Compare
In the original behaviour, the "children" checkboxes were working independently of the "parent" checkbox, i.e. they were clickable even if the "parent" was turned off. That was the main reason I grouped all 4 together and added a sepratate title for the whole group. If the intention was to disable the 3 checkboxes below if the first one is unchecked, we should create that dependency then and maybe, as you said, replace the first with a toggle switch to be more intuitive. |
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/ChordSymbolsPage.qml
Outdated
Show resolved
Hide resolved
@SilverGreen93 Re making it a toggle, it would be convenient to wait with that until #30561 is merged, because that gives the ToggleButton component the same interface as CheckBox (and, waiting would avoid a conflict). |
Update: that one is merged, so you can rebase and go ahead |
Resolves: musescore#30539 Rearrange the capitalization options such that they have more space for non-English languages to fit.
7975caf
to
68808e5
Compare
Much improved, good to go from the UI perspective! |
Resolves: #30539
Rearrange the capitalization options such that they have more space for non-English languages to fit.