Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Add missing async #706

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[test] Add missing async #706

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b44055
[test] Add missing async
oliviertassinari Oct 6, 2024
71f64e2
fix ci
oliviertassinari Oct 6, 2024
3da6e66
Add missing async
michaldudak Oct 8, 2024
471c153
wtf
michaldudak Oct 8, 2024
b177558
Fix flaky popover test
michaldudak Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mui-base/src/Tabs/Root/TabsRoot.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('<Tabs.Root />', () => {
tabElements[index].id,
);

await act(async () => {
await act(() => {
Copy link
Member

@michaldudak michaldudak Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: having an async here breaks 200+ other tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh strange, there is some black magic 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to switch to Vitest as soon as possible. At least test isolation works well there.

tabElements[index].click();
});

Expand Down