[test] Add missing async #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Netlify deploy preview |
oliviertassinari
force-pushed
the
test-async
branch
from
125a225
to
6b1e442
Compare
oliviertassinari
force-pushed
the
test-async
branch
from
6b1e442
to
3b44055
Compare
michaldudak
reviewed
Oct 8, 2024
| @@ -153,7 +153,7 @@ describe('<Tabs.Root />', () => { | |||
| tabElements[index].id, | |||
| ); | |||
|
|
|||
| await act(async () => { | |||
| await act(() => { | |||
There was a problem hiding this comment.
Fun fact: having an async here breaks 200+ other tests.
There was a problem hiding this comment.
Oh strange, there is some black magic 😅
There was a problem hiding this comment.
I'd love to switch to Vitest as soon as possible. At least test isolation works well there.
michaldudak
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoseasyncfunctions are noise, see the source of Act if you want to be sure: https://github.com/facebook/react/blob/main/packages/react/src/ReactAct.js.Edit: Ok, no, this look required mui/mui-public#174