Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactor and simplification of cast.py #458

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Major refactor and simplification of cast.py #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df03cd4
Drops the "reboot" feature, since it hasn't been supported in pychrom…
xsdg Feb 20, 2024
40b3773
Half-hearted refactor to separate the Sonos and Chromecast code that …
xsdg Feb 20, 2024
7ab8513
Renames "sonos" and "chromecast" to "has_sonos" and "has_chromecast" …
xsdg Feb 20, 2024
f2443e0
Creates an AvailableDevice dataclass, resolves the available_devices …
xsdg Mar 8, 2024
ded93ea
Updates the systray infrastructure to adopt the new AvailableDevice p…
xsdg Mar 8, 2024
deebb8d
Further cast.py simplifications.
xsdg Mar 8, 2024
97c96f7
Fixes an alternate codepath and performs extra simplification
xsdg Mar 8, 2024
20023f4
Minor fixups
xsdg Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions bin/mkchromecast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@ import mkchromecast
from mkchromecast.version import __version__
from mkchromecast.audio_devices import (inputint, inputdev, outputdev,
outputint)
from mkchromecast.cast import Casting
import mkchromecast.colors as colors
from mkchromecast import cast
from mkchromecast import colors
from mkchromecast.constants import OpMode
from mkchromecast.pulseaudio import create_sink, get_sink_list, remove_sink
from mkchromecast.utils import terminate, checkmktmp, writePidFile
from mkchromecast.messages import print_available_devices


def maybe_execute_single_action(mkcc: mkchromecast.Mkchromecast):
Expand Down Expand Up @@ -51,10 +50,10 @@ class CastProcess(object):
self.mkcc = mkcc

# Type declarations
self.cc: Casting
self.cc: cast.Casting

def run(self):
self.cc = Casting(self.mkcc)
self.cc = cast.Casting(self.mkcc)
checkmktmp()
writePidFile()

Expand Down
Loading