Major refactor and simplification of cast.py #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecast in years. There's the possibility of reintroducing this for Sonos, if that's still supported, but the Sonos support is tacked on right now in a way that really hurts the code design, so it'll make more sense to add that back, if needed, than to preserve the functionality in its current form.
…was patched together in a way that really hurts code readability, modularity, correctness, etc. This intentionally leaves the Sonos code disabled, so that we can hopefully refactor the Chromecast code into a better design. Then we can re-incorporate Sonos support into that design in a better way.
…to clarify their meanings.
…method/attribute ambiguity, and moves print_available_devices to the cast module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
available_devicesas being a method or a listprint_available_deviceshelper to cast.pyAlso, this avoids using
available_devicesas a global variable, which makes progress on #425