Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6353 prescribed quantity improvements #6387

Merged

Conversation

GeronimoJohn
Copy link
Contributor

Fixes #6353

πŸ‘©πŸ»β€πŸ’» What does this PR do?

This improves the logic for assigning the prescribed quantity. Instead of assigning it to each issued line, it only assigns the prescribed quantity to the first line that is issued.

Screen.Recording.2025-02-03.at.11.56.11.AM.mov

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

Check the network tab or through GraphQL Network plugin to check which issued line prescribed quantity is getting assigned to.

  • Edit or create a new prescription
  • A field called Prescribed Quantity is on the screen
  • The field should either be pre-filled with a default value or zero if there's none
  • The field can be updated to our desired prescribed quantity
    • Prescribed Quantity should only be saved on the first allocated line in the prescription.
    • Only 1 line should have prescribed quantity per prescription per item.
    • If the line containing the prescribed quantity is deleted or allocated 0 stock, the prescribed quantity should be saved to the next line.
    • Prescribed quantity can be saved against a placeholder line if no stock is allocated for that item

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@GeronimoJohn GeronimoJohn added this to the v2.6.0 milestone Feb 2, 2025
@github-actions github-actions bot removed this from the v2.6.0 milestone Feb 2, 2025
@github-actions github-actions bot added Team Piwakawaka James, Carl, John, Zachariah feature: dispensing labels Feb 2, 2025
@GeronimoJohn GeronimoJohn mentioned this pull request Feb 2, 2025
7 tasks
Copy link

github-actions bot commented Feb 2, 2025

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.26 MB 5.26 MB 260 B (0.00%)

Copy link
Contributor

@CarlosNZ CarlosNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll review this and the base properly once this is merged in.

@CarlosNZ CarlosNZ self-assigned this Feb 2, 2025
@GeronimoJohn GeronimoJohn merged commit 0c9e527 into 6180-prescribed-quantity Feb 2, 2025
5 of 6 checks passed
@GeronimoJohn GeronimoJohn deleted the 6353-prescribed-quantity-improvements branch February 2, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dispensing Team Piwakawaka James, Carl, John, Zachariah
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants