-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6180 prescribed quantity #6345
base: develop
Are you sure you want to change the base?
6180 prescribed quantity #6345
Conversation
Bundle size differenceComparing this PR to
|
A conversation about how the input behaves are still in discussion within its ticket - converting to a draft until we've decided the way to go |
Looking good John, I haven't dug into the code yet, will do that next. Just wanted to comment on the layout/behaviour first. I see you've had some discussion on the issue, so I don't want to contradict everything that was agreed there. My main concern was minimising the effort required for the user. In the vast majority of cases the Prescribed quantity will match the Issue quantity, so the user should only have to type the value once. But the way it is here, is initially focuses to the "Issue" quantity, and the "Prescribed" value stays at 0. Wouldn't it be better to put the inital focs on "Prescribed" so that the "Issue" value is filled automatically? Following on from that, I was just chatting to James, and we thought that the "Tab" key from "Prescribed" should take you straight to Directions, as most of the time that's what you'll want. Probably best just to have a quick IRL chat before changing anything though, so pop over and see me when you have a chance :) |
β¦tity-improvements 6353 prescribed quantity improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, John.
I've left a few comments, mostly pretty minor stuff.
There's one bug I noticed that I can't quickly figure out what's happening:
- Go into a prescription that already has lines (or create one), make sure there is a prescribed quantity and issue quantity for each.
- Add a new item, then save
- Now go back to the first item on the list and open the "Quantity" accordion -- the "Issue" quantity has been reset to 0! (If you refresh the page it'll come back).
Good luck tracking that one down :) j
client/packages/invoices/src/Prescriptions/LineEditView/PrescriptionLineEditForm.tsx
Outdated
Show resolved
Hide resolved
client/packages/invoices/src/Prescriptions/LineEditView/PrescriptionLineEditForm.tsx
Outdated
Show resolved
Hide resolved
client/packages/invoices/src/Prescriptions/LineEditView/PrescriptionLineEditForm.tsx
Outdated
Show resolved
Hide resolved
client/packages/invoices/src/Prescriptions/LineEditView/PrescriptionLineEditForm.tsx
Outdated
Show resolved
Hide resolved
client/packages/invoices/src/Prescriptions/LineEditView/PrescriptionLineEditForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the fixes.
And as discussed IRL, the other issue I found is actually this one and so nothing to do with your changes.
Happy to merge this now π
Fixes #6180
π©π»βπ» What does this PR do?
This update introduces a new field in the Line Edit View to record the prescribed quantity of an item. The field is editable and does not perform any calculations. The data entered in this field is saved to the database and synchronized with mSupply.
Screen.Recording.2025-01-31.at.12.08.23.PM.mov
π Any notes for the reviewer?
Left a comment for an improvement that will be worked on a different PR
π§ͺ Testing
π Documentation
1.
2.