Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5398 use store pref to hide extra columns #5407

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

roxy-dao
Copy link
Contributor

Fixes #5398

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Use store pref to hide extra columns in program requisitions until global pref is implemented

Screenshot 2024-11-14 at 4 54 02β€―PM

πŸ§ͺ Testing

  1. Enable preference
  • Have programs set up
  • Go to your store -> Preferences
  • Enable the Show extra fields on requisition preference
  • Go to OMS -> Sync
  • Create a program requisition for any store
  • See all the extra columns
  • Click on a line, also see the extra columns in the line edit page
  1. Disable Preference
  • Go back to mSupply
  • Go to your store -> Preferences
  • Disabled Show extra fields on requisition preference
  • Go to OMS -> Sync
  • Create program requisition for any store
  • See all extra columns gone
  • Click on lines, extra columns should be gone from here too

ALTERNATIVELY
Just set up two stores on your OMS site, have one with pref and one without and follow above

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.4.0-RC2 milestone Nov 14, 2024
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
4.97 MB 4.97 MB 619 B (0.01%)

@roxy-dao roxy-dao requested a review from Chris-Petty November 14, 2024 04:31
@roxy-dao roxy-dao linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

If we already just done the store pref... why both doing a global pref in the future... hmm.

@roxy-dao
Copy link
Contributor Author

Looks good to me!

If we already just done the store pref... why both doing a global pref in the future... hmm.

Global pref for more customisation. Store pref only hides the columns πŸ™ˆ

Base automatically changed from 5305-add-mutate-program-indicator-values to v2.4.0 November 14, 2024 23:36
@roxy-dao roxy-dao merged commit ce022e1 into v2.4.0 Nov 14, 2024
6 checks passed
@roxy-dao roxy-dao deleted the 5398-Use-Store-Pref-to-hide-extra-columns branch November 14, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Store Pref to hide extra columns
2 participants