Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing touches on new Releases API #1265

Merged
merged 17 commits into from
Apr 29, 2020

Conversation

bhearsum
Copy link
Contributor

@bhearsum bhearsum commented Apr 1, 2020

This patch adds what should be the final changes to the new Releases API for the time being. I uncovered a few bugs and needed features while working on #1290 and #1266, which this PR addresses. The changesets aren't as well organized as previous patches, but here's the overall highlights:

  • Add an endpoint that can enact V2 release scheduled changes
  • Add required_signoffs and product_required_signoffs to /v2/releases response
  • Make it possible to cancel existing scheduled changes with PUT to /v2/releases/{name}. This can be done by posting the current version of the Release. This was needed to make it possible to edit existing scheduled changes through the UI. (Sidenote: I originally pursued a strategy of having the backend analyze the current release & scheduled change against the new proposed scheduled change, and have it create/modify/delete the release & scheduled changes as necessary -- but it proved extremely unwieldy, and I decided this was probably the better route.)
  • Modify Scheduled Change response to include signoffs and when to allow the UI to update properly.
  • Update rule edit endpoints to allow V2 Releases to be used in Rules
  • Fix bug where sc_blob was being partly populated in /v2/releases/{name} response when only an asset had a scheduled change (ie: no scheduled change to the base)
  • Ignore signoff requirements when marking a Release read only
  • Fix a few cases where we treating completed scheduled changes as still active
  • Always set product when scheduling changes in set_release to avoid it getting set to None.
  • Fix bug where we couldn't delete Releases with scheduled changes, because the database layer complained

@bhearsum bhearsum force-pushed the 3.5-final-api-changes branch from 26cf7a9 to 748bbf3 Compare April 17, 2020 18:05
@bhearsum bhearsum changed the title [wip] Finishing touches on new Releases API Finishing touches on new Releases API Apr 17, 2020
…nses; add required signoff info to /releases endpoint
@bhearsum bhearsum marked this pull request as ready for review April 17, 2020 19:41
@nthomas-mozilla
Copy link
Contributor

👍

@bhearsum bhearsum merged commit ebb5685 into mozilla-releng:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants