-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finishing touches on new Releases API #1265
Merged
bhearsum
merged 17 commits into
mozilla-releng:master
from
bhearsum:3.5-final-api-changes
Apr 29, 2020
Merged
Finishing touches on new Releases API #1265
bhearsum
merged 17 commits into
mozilla-releng:master
from
bhearsum:3.5-final-api-changes
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6216a97
to
54ce340
Compare
22f4e3f
to
26cf7a9
Compare
…d that only affects assets
26cf7a9
to
748bbf3
Compare
…nses; add required signoff info to /releases endpoint
nthomas-mozilla
approved these changes
Apr 27, 2020
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds what should be the final changes to the new Releases API for the time being. I uncovered a few bugs and needed features while working on #1290 and #1266, which this PR addresses. The changesets aren't as well organized as previous patches, but here's the overall highlights:
required_signoffs
andproduct_required_signoffs
to/v2/releases
responsePUT
to/v2/releases/{name}
. This can be done by posting the current version of the Release. This was needed to make it possible to edit existing scheduled changes through the UI. (Sidenote: I originally pursued a strategy of having the backend analyze the current release & scheduled change against the new proposed scheduled change, and have it create/modify/delete the release & scheduled changes as necessary -- but it proved extremely unwieldy, and I decided this was probably the better route.)signoffs
andwhen
to allow the UI to update properly.sc_blob
was being partly populated in/v2/releases/{name}
response when only an asset had a scheduled change (ie: no scheduled change to the base)product
when scheduling changes inset_release
to avoid it getting set to None.