Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor some uses of getPotentialRequiredSignoffs #1304

Open
bhearsum opened this issue Apr 28, 2020 · 0 comments
Open

refactor some uses of getPotentialRequiredSignoffs #1304

bhearsum opened this issue Apr 28, 2020 · 0 comments
Labels
db database layer

Comments

@bhearsum
Copy link
Contributor

bhearsum commented Apr 28, 2020

This pattern is used often (but not exclusively) with getPotentialRequiredSignoffs. It might be possible (at some point) to refactor the function so that it returns the data without further manipulation ?

potential_required_signoffs = [
    obj for v in self.getPotentialRequiredSignoffs([row, new_row], transaction=transaction).values() for obj in v
]

Originally posted by @nthomas-mozilla in #1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db database layer
Projects
None yet
Development

No branches or pull requests

1 participant