This repository has been archived by the owner on Nov 13, 2017. It is now read-only.
remove ~RobotModelLoader #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destructor only resetted shared_ptr of the class. This automatically happens after the destructor anyway and it does disturb the default destructor order of the data structures.
|
+1 makes sense to me, those classes already clear themselves |
|
@v4hn I tested this and it works for me in my cpp code! |
|
Checking with AddressSanitizer, this PR of course doesn't resolve #592, although - by chance - it doesn't crashes the program in normal operation mode anymore. |
v4hn
added a commit
that referenced
this pull request
Jul 7, 2016
This reverts commit 93d76a8. This is not ABI-compatible, so remove it from indigo-devel.
|
Only noticed now: Probably this PR destroys ABI compatibility, because it now falls back to the default destructor? |
v4hn
added a commit
that referenced
this pull request
Jul 7, 2016
The destructor only resetted shared_ptr of the class. This automatically happens after the destructor anyway and it does disturb the default destructor order of the data structures.
|
I have no idea why I failed to notice that before merging,
but it is ABI breaking. Therefore I reverted the change in indigo-devel
and applied it to jade-devel only.
|
|
What if you simply remove the .reset() from the destructor ? |
|
Sure, but
|
alainsanguinetti
pushed a commit
to alainsanguinetti/moveit_ros
that referenced
this pull request
Jul 8, 2016
The destructor only resetted shared_ptr of the class. This automatically happens after the destructor anyway and it does disturb the default destructor order of the data structures.
alainsanguinetti
pushed a commit
to alainsanguinetti/moveit_ros
that referenced
this pull request
Jul 8, 2016
This reverts commit 93d76a8. This is not ABI-compatible, so remove it from indigo-devel.
otamachan
pushed a commit
to otamachan/moveit_ros
that referenced
this pull request
Oct 22, 2017
The destructor only resetted shared_ptr of the class. This automatically happens after the destructor anyway and it does disturb the default destructor order of the data structures.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destructor only resetted shared_ptr of the class.
This automatically happens after the destructor finished anyway and the explicit resets disturb the default destructor order of the data structures.
Additionally this has the same effect as #702 and for some reason works around #592 over here.
This is not meant as a fix for #592, but it resolves the problem for the moment without adding new unnecessary code.
The real bug, as @rhaschke pointed out, lies in internal design faults of pluginlib and class_loader and has to be resolved there.