Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable cmake warnings (#3028) (backport #3172) #3173

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 17, 2024

Description

I think we should be able to do this now

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3172 done by [Mergify](https://mergify.com).

@mikeferguson
Copy link
Contributor

Good call - I didn't even think about backporting it

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.07%. Comparing base (e94c891) to head (0334948).
Report is 2 commits behind head on jazzy.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3173      +/-   ##
==========================================
- Coverage   44.07%   44.07%   -0.00%     
==========================================
  Files         698      698              
  Lines       61535    61539       +4     
  Branches     7457     7458       +1     
==========================================
+ Hits        27115    27116       +1     
- Misses      34252    34255       +3     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeferguson
Copy link
Contributor

Apparently, we've still got issues on Jazzy:

  In file included from /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_ros/moveit_servo/src/servo_node.cpp:42:
  /opt/ros/jazzy/include/realtime_tools/realtime_tools/thread_priority.hpp:39:2: error: #warning "This header include is deprecated. Please update your code to use 'realtime_helpers.hpp' header and link against 'realtime_tools' library." [-Werror=cpp]

@sea-bass
Copy link
Contributor

Ah yeah, there's another bit of code to backport. Will add it to this PR

@mikeferguson mikeferguson merged commit 4489d3b into jazzy Dec 18, 2024
7 checks passed
@mikeferguson mikeferguson deleted the mergify/bp/jazzy/pr-3172 branch December 18, 2024 01:56
@mikeferguson mikeferguson restored the mergify/bp/jazzy/pr-3172 branch December 18, 2024 01:56
@mikeferguson mikeferguson deleted the mergify/bp/jazzy/pr-3172 branch December 18, 2024 01:56
@mikeferguson
Copy link
Contributor

@sea-bass thanks for figuring out the build error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants