-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Humble] Add tutorial docker CI job and remove ci-testing job #3082
Conversation
Please target the |
@sjahr Do you have the powers to remove the "Required" tag from the CI jobs that I've removed here? Or rather, replace it with the new one? |
453ea72
to
2456deb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3082 +/- ##
==========================================
+ Coverage 51.15% 51.25% +0.10%
==========================================
Files 382 382
Lines 31902 31865 -37
==========================================
+ Hits 16317 16328 +11
+ Misses 15585 15537 -48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs adaption of the required CI jobs. Unfortunately, I don't have permissions to change those either.
Description
This PR adds the tutorial docker CI job specific to Humble, which was removed from main in #3081.
It also removes the
ci-testing
Docker build from this branch, since theosrf/ros2:testing
image is now on Ubuntu 24.04 and does not have the humble ROS binaries.Checklist